[PATCH 1/2] xen: Add dependency on armv8

[Marek Vasut]

On 4/12/23 09:10, Michal Simek wrote:
> 
> 
> On 4/12/23 06:57, Marek Vasut wrote:
>> On 4/11/23 13:23, Michal Simek wrote:
>>> Xen core calls HYPERVISOR_memory_op() in map_shared_info() which is 
>>> just in
>>> xen_init() called from init_sequence_r[].
>>>
>>> Xen can run only on armv8 where HVC calls are implemented that's why 
>>> enable
>>> it only for arm64.
>>
>> Doesn't ARMv7a also support HYP mode ?
> 
> 
> Xen code in U-Boot is wired via HYPERVISOR_* functions which are wired 
> only for armv8.

This should go into the commit message ^ as this is useful information.

> arch/arm/cpu/armv8/xen/hypercall.S:56:.globl HYPERVISOR_##hypercall;      \
> arch/arm/cpu/armv8/xen/hypercall.S:58:HYPERVISOR_##hypercall:        \
> arch/arm/cpu/armv8/xen/hypercall.S:59:  mov x16, 
> #__HYPERVISOR_##hypercall;     \

The commit message should be updated to something like 'U-Boot currently 
implements ... <functionality> ... only for ARM64, add dependency on 
ARM64. The hardware functionality is also available on ARMv7a, but 
currently not supported by U-Boot, hence it is not added to the list of 
dependencies here.'

Basically don't say "armv8 where HVC calls are implemented" , because 
that can be misinterpreted as "only on armv8 hardware which implements 
the HVC extensions".

Or something like that, adjust as you see fit.