[PATCH] dm: core: introduce uclass_get_device_by_of_path()

Rasmus Villemoes rasmus.villemoes at prevas.dk
Thu Apr 13 17:17:03 CEST 2023


There's quite a few instances of board-specific code doing

  off = fdt_path_offset(gd->fdt_blob, ...);
  ...
  ret = uclass_get_device_by_of_offset(..., off, &dev);

looking for an eeprom or a pmic via some alias. Such code can be
simplified a little if we have a helper for directly getting a device
via device tree path (including being given as an alias).

Implement it in terms of ofnode rather than raw offsets so that this
will work whether live tree is enabled or not.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
---
 drivers/core/uclass.c |  6 ++++++
 include/dm/uclass.h   | 17 +++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c
index 3a919104a6..56ea878701 100644
--- a/drivers/core/uclass.c
+++ b/drivers/core/uclass.c
@@ -544,6 +544,12 @@ int uclass_get_device_by_ofnode(enum uclass_id id, ofnode node,
 	return uclass_get_device_tail(dev, ret, devp);
 }
 
+int uclass_get_device_by_of_path(enum uclass_id id, const char *path,
+				 struct udevice **devp)
+{
+	return uclass_get_device_by_ofnode(id, ofnode_path(path), devp);
+}
+
 #if CONFIG_IS_ENABLED(OF_CONTROL)
 int uclass_get_device_by_phandle_id(enum uclass_id id, uint phandle_id,
 				    struct udevice **devp)
diff --git a/include/dm/uclass.h b/include/dm/uclass.h
index ee15c92063..5c5fb9acac 100644
--- a/include/dm/uclass.h
+++ b/include/dm/uclass.h
@@ -264,6 +264,23 @@ int uclass_get_device_by_of_offset(enum uclass_id id, int node,
 int uclass_get_device_by_ofnode(enum uclass_id id, ofnode node,
 				struct udevice **devp);
 
+/**
+ * uclass_get_device_by_of_path() - Get a uclass device by device tree path
+ *
+ * This searches the devices in the uclass for one attached to the
+ * device tree node corresponding to the given path (which may also be
+ * an alias).
+ *
+ * The device is probed to activate it ready for use.
+ *
+ * @id: ID to look up
+ * @node: Device tree path to search for (if no such path then -ENODEV is returned)
+ * @devp: Returns pointer to device (there is only one for each node)
+ * Return: 0 if OK, -ve on error
+ */
+int uclass_get_device_by_of_path(enum uclass_id id, const char *path,
+				 struct udevice **devp);
+
 /**
  * uclass_get_device_by_phandle_id() - Get a uclass device by phandle id
  *
-- 
2.37.2



More information about the U-Boot mailing list