[PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support

Thu Apr 13 21:11:12 CEST 2023

чт, 13 квіт. 2023 р. о 20:13 Tom Warren <TWarren at nvidia.com> пише:
>
> Svyatoslav,
>
> I tried to build w/V2 of your Nexus patches applied to TOT u-boot-tegra/master, and I get these errors from 'buildman tegra':
>
>    aarch64:  +   p2771-0000-000
> +In file included from arch/arm/mach-tegra/fuse.c:16:0:
> +arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: asm/arch/clock-tables.h: No such file or directory
> + #include <asm/arch/clock-tables.h>
> +          ^~~~~~~~~~~~~~~~~~~~~~~~~
> +compilation terminated.
> +make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1
> +make[1]: *** [arch/arm/mach-tegra] Error 2
> +make: *** [sub-make] Error 2
>    aarch64:  +   p2771-0000-500
> +In file included from arch/arm/mach-tegra/fuse.c:16:0:
> +arch/arm/include/asm/arch-tegra/clock.h:42:10: fatal error: asm/arch/clock-tables.h: No such file or directory
> + #include <asm/arch/clock-tables.h>
> +          ^~~~~~~~~~~~~~~~~~~~~~~~~
> +compilation terminated.
> +make[2]: *** [arch/arm/mach-tegra/fuse.o] Error 1
> +make[1]: *** [arch/arm/mach-tegra] Error 2
> +make: *** [sub-make] Error 2
>
> These are the two T186 builds, they don't have or use a clock-tables.h .
>
> Please test building your patchset on TOT u-boot-tegra/master _before_ posting. Use buildman (preferred) or 'make xxx_defconfig && make' for each Tegra board (cumbersome).
>
> I won't take any future patches from you unless they're marked w/'passes buildman' or 'each Tegra board builds OK w/make', etc.  I certainly can't push a PR to TomR if it fails to build.

Thank you! I have reloaded patches with fixes. It passed
./tools/buildman/buildman -Pr tegra or do I need to run other tests.
If yes, pls specify which.

Best regards,
Svyatoslav R.

> Tom
>
> -----Original Message-----
> From: Svyatoslav Ryhel <clamor95 at gmail.com>
> Sent: Wednesday, April 12, 2023 11:05 PM
> To: Tom Warren <TWarren at nvidia.com>
> Cc: Marek Vasut <marex at denx.de>; Philippe Reynes <philippe.reynes at softathome.com>; Marcel Ziswiler <marcel.ziswiler at toradex.com>; Fabio Estevam <festevam at denx.de>; Simon Glass <sjg at chromium.org>; Jonas Schwöbel <jonasschwoebel at yahoo.de>; u-boot at lists.denx.de
> Subject: Re: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
>
> External email: Use caution opening links or attachments
>
>
> чт, 13 квіт. 2023 р. о 02:07 Tom Warren <TWarren at nvidia.com> пише:
> >
> > Svyatoslav,
> >
> > This series (patches 3 & 4, in particular) fails when applied to u-boot-tegra/master TOT. Error snippet is below (from make p2771-0000-500_defconfig && make):
> >
> > CC      arch/arm/mach-tegra/fuse.o
> > arch/arm/mach-tegra/fuse.c:14:10: fatal error: asm/arch/clock.h: No
> > such file or directory  #include <asm/arch/clock.h>
> >           ^~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > scripts/Makefile.build:256: recipe for target
> > 'arch/arm/mach-tegra/fuse.o' failed
> > make[1]: *** [arch/arm/mach-tegra/fuse.o] Error 1
> > Makefile:1845: recipe for target 'arch/arm/mach-tegra' failed
> > make: *** [arch/arm/mach-tegra] Error 2
>
> Hello Tom.
>
> Thanks for your check. Issue was caused by non exposed headers for T186.
> I have fixed that in v2, I hope buildman will pass. Additionally I have modified grouper defconfig in such a way that it should pass even without device fragment.
>
> Best regards,
> Svyatoslav R.
>
> >
> > buildman/tegra also fails for that board, and 2 others.  Removing those two patches (3 & 4 in your Nexus7 patchset) gets make & buildman working again.
> > Buildman/tegra worked fine on the base u-boot-tegra/master repo (before I applied your patchset w/git am).
> >
> > PTAL,
> >
> > Tom
> >
> > -----Original Message-----
> > From: Svyatoslav Ryhel <clamor95 at gmail.com>
> > Sent: Wednesday, April 12, 2023 12:50 PM
> > To: Tom Warren <twarren at nvidia.com>; Svyatoslav Ryhel
> > <clamor95 at gmail.com>; Marek Vasut <marex at denx.de>; Philippe Reynes
> > <philippe.reynes at softathome.com>; Marcel Ziswiler
> > <marcel.ziswiler at toradex.com>; Fabio Estevam <festevam at denx.de>; Simon
> > Glass <sjg at chromium.org>; Jonas Schwöbel <jonasschwoebel at yahoo.de>
> > Cc: u-boot at lists.denx.de
> > Subject: [PATCH v1 0/4] Tegra: add ASUS/Google Nexus 7 (2012) support
> >
> > External email: Use caution opening links or attachments
> >
> >
> > This patchset adds support for native use of U-Boot on ASUS/Google Nexus 7 (2012), aka grouper/tilapia as a replacement of vendor bootloader. Alongside device bringup tegra requires few small patches:
> >  - add gpio keyboard as stdin device
> >  - make networking boot options optional
> >  - add a small tool to generate SoC UID
> >
> > Jonas Schwöbel (1):
> >   configs: tegra-common-post: make PXE and DHCP boot targets optional
> >
> > Svyatoslav Ryhel (3):
> >   configs: tegra-common-post: add GPIO keyboard as STDIN device
> >   ARM: tegra: add SoC UID calculation function
> >   board: asus: grouper: add Google Nexus 7 (2012) support
> >
> >  arch/arm/dts/Makefile                         |   3 +
> >  arch/arm/dts/tegra30-asus-grouper-common.dtsi | 125 ++++++  .../dts/tegra30-asus-nexus7-grouper-E1565.dts |  40 ++  .../dts/tegra30-asus-nexus7-grouper-PM269.dts |  65 ++++  .../dts/tegra30-asus-nexus7-tilapia-E1565.dts |  40 ++
> >  arch/arm/include/asm/arch-tegra/fuse.h        |   7 +
> >  arch/arm/mach-tegra/Makefile                  |   2 +-
> >  arch/arm/mach-tegra/fuse.c                    | 151 ++++++++
> >  arch/arm/mach-tegra/tegra30/Kconfig           |   5 +
> >  board/asus/grouper/Kconfig                    |  20 +
> >  board/asus/grouper/MAINTAINERS                |   6 +
> >  board/asus/grouper/Makefile                   |  14 +
> >  board/asus/grouper/grouper-spl-max.c          |  46 +++
> >  board/asus/grouper/grouper-spl-ti.c           |  42 ++
> >  board/asus/grouper/grouper.c                  | 209 ++++++++++
> >  board/asus/grouper/pinmux-config-grouper.h    | 362 ++++++++++++++++++
> >  configs/grouper_E1565.config                  |   2 +
> >  configs/grouper_PM269.config                  |   2 +
> >  configs/grouper_common_defconfig              |  85 ++++
> >  configs/tilapia.config                        |   3 +
> >  include/configs/grouper.h                     |  68 ++++
> >  include/configs/tegra-common-post.h           |  28 +-
> >  22 files changed, 1319 insertions(+), 6 deletions(-)  create mode
> > 100644 arch/arm/dts/tegra30-asus-grouper-common.dtsi
> >  create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-E1565.dts
> >  create mode 100644 arch/arm/dts/tegra30-asus-nexus7-grouper-PM269.dts
> >  create mode 100644 arch/arm/dts/tegra30-asus-nexus7-tilapia-E1565.dts
> >  create mode 100644 arch/arm/mach-tegra/fuse.c  create mode 100644
> > board/asus/grouper/Kconfig  create mode 100644
> > board/asus/grouper/MAINTAINERS  create mode 100644
> > board/asus/grouper/Makefile  create mode 100644
> > board/asus/grouper/grouper-spl-max.c
> >  create mode 100644 board/asus/grouper/grouper-spl-ti.c
> >  create mode 100644 board/asus/grouper/grouper.c  create mode 100644
> > board/asus/grouper/pinmux-config-grouper.h
> >  create mode 100644 configs/grouper_E1565.config  create mode 100644
> > configs/grouper_PM269.config  create mode 100644
> > configs/grouper_common_defconfig  create mode 100644
> > configs/tilapia.config  create mode 100644 include/configs/grouper.h
> >
> > --
> > 2.37.2
> >