[PATCH V2 0/2] net: phy: Make phy_interface_is_sgmii|rgmii a switch statement
Nishanth Menon
nm at ti.com
Fri Apr 14 06:24:31 CEST 2023
Originally reported by Tom[1], turned out to be that recent commit
75d28899e3e9 ("net: phy: Synchronize PHY interface modes with Linux")
reordered the enum definitions which in turn broke the range checks.
we are left with two options:
a) check against explicit values to help reuse as much as possible and
let compiler optimize where applicable
or
b) be very explicit in phy drivers and drop these helpers.
I have chosen to go with (a) approach.
Tested on am64x, though the dp83867 is used elsewhere as well.
Changes since v1:
* Change in switch handling (Thanks Marek for the suggestion)
V1: https://lore.kernel.org/all/20230413180713.2922524-1-nm@ti.com/
Nishanth Menon (2):
net: phy: Make phy_interface_is_sgmii a switch statement
net: phy: Make phy_interface_is_rgmii a switch statement
include/phy.h | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
--
2.40.0
More information about the U-Boot
mailing list