[PATCH v2 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

Kever Yang kever.yang at rock-chips.com
Fri Apr 14 10:55:40 CEST 2023


On 2023/3/18 00:29, Eugen Hristev wrote:
> To be able to initialize the pinctrl correctly at SPL level and read
> u-boot proper from SD-Card, the pinctrl must be initialized.
>
> Signed-off-by: Eugen Hristev <eugen.hristev at collabora.com>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
> Changes in v2:
> - add u-boot,dm-spl to pull up nodes, to also setup the pull control
> correctly. Also, in the loop that initializes multiple pins, only the
> first will be muxed as the loop will break when the pull up node is not
> found.
>
>   arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 26 +++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> index e1d240baf35d..a9d506ba6515 100644
> --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> @@ -124,6 +124,8 @@
>   };
>   
>   &pinctrl {
> +	u-boot,dm-spl;
> +
>   	usb {
>   		vcc5v0_host_en: vcc5v0-host-en {
>   			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> @@ -131,6 +133,30 @@
>   	};
>   };
>   
> +&pcfg_pull_up_drv_level_2 {
> +	u-boot,dm-spl;
> +};
> +
> +&pcfg_pull_up {
> +	u-boot,dm-spl;
> +};
> +
> +&sdmmc_bus4 {
> +	u-boot,dm-spl;
> +};
> +
> +&sdmmc_clk {
> +	u-boot,dm-spl;
> +};
> +
> +&sdmmc_cmd {
> +	u-boot,dm-spl;
> +};
> +
> +&sdmmc_det {
> +	u-boot,dm-spl;
> +};
> +
>   &usb_host0_ehci {
>   	companion = <&usb_host0_ohci>;
>   	phys = <&u2phy2_host>;


More information about the U-Boot mailing list