[PATCH V2 1/2] net: phy: Make phy_interface_is_sgmii a switch statement

Marek Vasut marek.vasut at mailbox.org
Fri Apr 14 13:22:20 CEST 2023


On 4/14/23 06:24, Nishanth Menon wrote:
> Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes
> with Linux") reordered the enum definitions. This caused the range of
> enums that this api was checking to go bad.
> 
> While it is possible for the phy drivers to practically use the enum's
> directly, drivers such as dp83867 use this helper to manage the
> configuration of the phy correctly.
> 
> Reported-by: Tom Rini <trini at konsulko.com>
> Signed-off-by: Nishanth Menon <nm at ti.com>

Reviewed-by: Marek Vasut <marek.vasut+renesas at mailbox.org>

It would be nice if you could do a follow-up patch as suggested by Marek 
Behun and inline this function into the TI PHY driver instead.


More information about the U-Boot mailing list