[PATCH V2 2/2] net: phy: Make phy_interface_is_rgmii a switch statement
Marek Vasut
marek.vasut at mailbox.org
Fri Apr 14 13:21:24 CEST 2023
On 4/14/23 06:24, Nishanth Menon wrote:
> Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes
> with Linux") reordered the enum definitions. This exposed a problem in
> range checking functions to identify the interface type. Though this
> specific api was'nt impacted (all the RGMII definitions remained within
Nit: "wasn't" , apostrophe in the wrong place .
> range), this experience should be used to never to have to face this
> kind of challenge again.
>
> While it is possible for the phy drivers to practically use the enum's
> directly, drivers such as dp83867, dp83869, marvell, micrel_ksz90x1 etc
> use the same.
>
> Reported-by: Tom Rini <trini at konsulko.com>
> Signed-off-by: Nishanth Menon <nm at ti.com>
Reviewed-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
More information about the U-Boot
mailing list