[PATCH 04/23] arm: dts: k3-am642-sk: Fix mmc1 pinmux pull polarity

[Roger Quadros]

On 14/04/2023 10:57, Nishanth Menon wrote:
> Fix the pinmux pull polarity.
> 
> This is a pending upstream kernel updates as of v6.3-rc6.
> 
> Signed-off-by: Nishanth Menon <nm at ti.com>
> ---
> Sent to kernel.org https://lore.kernel.org/linux-devicetree/20230414073328.381336-1-nm@ti.com/

Link to actual patch is
https://lore.kernel.org/linux-devicetree/20230414073328.381336-3-nm@ti.com/

> 
>  arch/arm/dts/k3-am642-sk.dts | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/dts/k3-am642-sk.dts b/arch/arm/dts/k3-am642-sk.dts
> index 4fb279489cfc..cc2027417e86 100644
> --- a/arch/arm/dts/k3-am642-sk.dts
> +++ b/arch/arm/dts/k3-am642-sk.dts
> @@ -223,15 +223,17 @@
>  
>  &main_pmx0 {
>  	main_mmc1_pins_default: main-mmc1-pins-default {
> +		/* XXX: Kernel-Upstream: TODO: Upstream (pull changes) */

Do we really want to sprinkle these comments in u-boot upstream?
If we are quite sure this makes to upstream kernel we might as well pull them into
u-boot as is.

>  		pinctrl-single,pins = <
> -			AM64X_IOPAD(0x0294, PIN_INPUT, 0) /* (J19) MMC1_CMD */
> +			AM64X_IOPAD(0x029c, PIN_INPUT_PULLUP, 0) /* (C20) MMC1_SDWP */
> +			AM64X_IOPAD(0x0298, PIN_INPUT_PULLUP, 0) /* (D19) MMC1_SDCD */
> +			AM64X_IOPAD(0x0294, PIN_INPUT_PULLUP, 0) /* (J19) MMC1_CMD */
>  			AM64X_IOPAD(0x0290, PIN_INPUT, 0) /* (#N/A) MMC1_CLKLB */
> -			AM64X_IOPAD(0x028c, PIN_INPUT, 0) /* (L20) MMC1_CLK */
> -			AM64X_IOPAD(0x0288, PIN_INPUT, 0) /* (K21) MMC1_DAT0 */
> -			AM64X_IOPAD(0x0284, PIN_INPUT, 0) /* (L21) MMC1_DAT1 */
> -			AM64X_IOPAD(0x0280, PIN_INPUT, 0) /* (K19) MMC1_DAT2 */
> -			AM64X_IOPAD(0x027c, PIN_INPUT, 0) /* (K18) MMC1_DAT3 */
> -			AM64X_IOPAD(0x0298, PIN_INPUT, 0) /* (D19) MMC1_SDCD */
> +			AM64X_IOPAD(0x028c, PIN_INPUT_PULLDOWN, 0) /* (L20) MMC1_CLK */
> +			AM64X_IOPAD(0x0288, PIN_INPUT_PULLUP, 0) /* (K21) MMC1_DAT0 */
> +			AM64X_IOPAD(0x0284, PIN_INPUT_PULLUP, 0) /* (L21) MMC1_DAT1 */
> +			AM64X_IOPAD(0x0280, PIN_INPUT_PULLUP, 0) /* (K19) MMC1_DAT2 */
> +			AM64X_IOPAD(0x027c, PIN_INPUT_PULLUP, 0) /* (K18) MMC1_DAT3 */
>  		>;
>  	};
>  

cheers,
-roger