[PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

[Jassi Brar]

On Mon, 17 Apr 2023 at 01:38, Michal Simek <michal.simek at amd.com> wrote:
> On 4/14/23 17:02, Jassi Brar wrote:

> >>>>> +
> >>>>> +/* This will dynamically allocate the fwu_mdata */
> >>>>> +#define CONFIG_FWU_NUM_BANKS         0
> >>>>> +#define CONFIG_FWU_NUM_IMAGES_PER_BANK       0
> >>>>
> >>>> These two are completely unused.
> >>>>
> >>> these are necessary for include/fwu_mdata.h that comes later.
> >>
> >> If that's come later, add it later.
> >>
> > Can you please actually look at the code to see the underlying constraint?
>
> Ok. I misunderstand your comment.
>
> You have it there because of #include <fwu_mdata.h> and using macros there.
> Can you just allocated that structures at run time instead of statically defined
> them via array? That would clean that design and also fix checkpatch issue.
>
I can't see how dynamically allocating an array of packed structures
inside an array of packed structures , makes the design any cleaner.

I think this is a valid case where we can ignore the checkpatch
warning because we know what we are doing.

-jassi