[PATCH v4 07/10] ARM: rzn1: basic support for Renesas RZ/N1 SoC

[Marek Vasut]

On 3/8/23 21:26, Ralph Siemsen wrote:

[...]

> +++ b/arch/arm/Kconfig
> @@ -1031,6 +1031,21 @@ config ARCH_RMOBILE
>   	imply SYS_THUMB_BUILD
>   	imply ARCH_MISC_INIT if DISPLAY_CPUINFO
>   
> +config ARCH_RZN1
> +	bool "Reneasa RZ/N1 SoC"
> +	select CLK
> +	select CLK_RENESAS
> +	select CLK_R9A06G032

Does 'select CLK_R9A06G032' automatically activate the dependencies like 
'CLK_RENESAS' too ?

> +	select DM
> +	select DM_ETH
> +	select DM_SERIAL
> +	select PINCTRL
> +	select PINCONF
> +	select REGMAP
> +	select SYSRESET
> +	select SYSRESET_SYSCON
> +	imply CMD_DM
> +
>   config ARCH_SNAPDRAGON
>   	bool "Qualcomm Snapdragon SoCs"
>   	select ARM64
> @@ -2207,6 +2222,8 @@ source "arch/arm/mach-owl/Kconfig"
>   
>   source "arch/arm/mach-rmobile/Kconfig"
>   
> +source "arch/arm/mach-rzn1/Kconfig"

Should this be in mach-rmobile (which, maybe, should be renamed to 
mach-renesas) ?

[...]

> diff --git a/arch/arm/mach-rzn1/cpu_info.c b/arch/arm/mach-rzn1/cpu_info.c
> new file mode 100644
> index 0000000000..37c2492b51
> --- /dev/null
> +++ b/arch/arm/mach-rzn1/cpu_info.c
> @@ -0,0 +1,19 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +
> +#include <common.h>
> +#include <cpu_func.h>
> +
> +#if !CONFIG_IS_ENABLED(SYS_DCACHE_OFF)
> +void enable_caches(void)
> +{

Why not enable icache with icache_enable() too ?

> +	dcache_enable();
> +}
> +#endif
> +
> +#ifdef CONFIG_DISPLAY_CPUINFO
> +int print_cpuinfo(void)
> +{
> +	printf("CPU: Renesas Electronics RZ/N1\n");
> +	return 0;
> +}
> +#endif