[PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

Patrice CHOTARD patrice.chotard at foss.st.com
Tue Apr 18 09:21:23 CEST 2023


Hi Marek

On 4/17/23 19:00, Marek Vasut wrote:
> On 4/17/23 18:56, Patrice Chotard wrote:
>> In case USB hub regulator is shared, unexpected behavior occurs.
>> On stm32mp135f-dk, stm32mp157c-ev1 and stm32mp157x-dkx, regulator
>> v3v3 is shared between several IP/devices (USB, panel, ethernet phy,
>> camera, ...).
>> Running command "usb stop", v3v3 regulator is switched off and
>> the splashscreen content disappear.
>>
>> v3v3 shouldn't be disabled on usb_onboard_hub_remove() callback.
> 
> Isn't the regulator enable/disable refcounted ?

There is no refcount on regulator that's why we let regulator enable.

> If not, it should be, that would be the correct fix.

Thanks
Patrice


More information about the U-Boot mailing list