[PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

[Simon Glass]

Hi,

On Fri, 14 Apr 2023 at 07:53, Michal Simek <michal.simek at amd.com> wrote:
>
>
>
> On 4/10/23 06:25, Jassi Brar wrote:
> > On Wed, 29 Mar 2023 at 15:02, Simon Glass <sjg at chromium.org> wrote:
> >>
> >> Hi,
> >>
> >> On Tue, 28 Mar 2023 at 10:16, <jassisinghbrar at gmail.com> wrote:
> >>>
> >>> From: Masami Hiramatsu <masami.hiramatsu at linaro.org>
> >>>
> >>> Add 'mkfwumdata' tool to generate FWU metadata image for the meta-data
> >>> partition to be used in A/B Update imeplementation.
> >>>
> >>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu at linaro.org>
> >>> Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> >>> Signed-off-by: Jassi Brar <jaswinder.singh at linaro.org>
> >>> ---
> >>>   tools/Kconfig      |   9 ++
> >>>   tools/Makefile     |   4 +
> >>>   tools/mkfwumdata.c | 334 +++++++++++++++++++++++++++++++++++++++++++++
> >>>   3 files changed, 347 insertions(+)
> >>>   create mode 100644 tools/mkfwumdata.c
> >>
> >> Can you please look at putting this in binman instead, since we would
> >> rather not have another tool with no tests.
> >>
> > Must I do that? I have no history with binman and it seems the
> > mkfwumdata.c would need to be rewritten in python?
>
> I think it is about calling this utility from python not about rewriting it to
> python.

Yes that's the question. If this tool is for creating firmware
updates, then how are they created? I would expect binman to handle
this when U-Boot is built. Then you can build in some tests in binman
perhaps?

How does one know what parameters to pass? Is the documentation for
this tool elsewhere? Where are the tests?

It is also unfortunate that this seems to be inventing yet another
format (I recall that FIP was invented at one point also), when it
could use FIT.

Regards,
Simon