[PATCH v1 2/6] video: bridge: add Solomon SSD2825 DSI/LVDS driver

[Simon Glass]

Hi Svyatoslav,

On Wed, 19 Apr 2023 at 13:17, Svyatoslav Ryhel <clamor95 at gmail.com> wrote:
>
> SSD2825 is an innovative and cost-effective MIPI Bridge Chip solution
> targeting high resolution smartphones. It can convert 24bit RGB
> interface into 4-lane MIPI-DSI interface to drive extremely high
> resolution display modules of up to 800 x 1366, while supporting AMOLED,
> a-si LCD or LTPS advanced panel technologies for smartphone applications.
>
> Bridge is wrapped in panel uClass model for wider compatibility.
>
> Tested-by: Andreas Westman Dorcsak <hedmoo at yahoo.com> # LG P880 T30
> Tested-by: Svyatoslav Ryhel <clamor95 at gmail.com> # LG P895 T30
> Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> ---
>  drivers/video/bridge/Kconfig   |   7 +
>  drivers/video/bridge/Makefile  |   1 +
>  drivers/video/bridge/ssd2825.c | 523 +++++++++++++++++++++++++++++++++
>  3 files changed, 531 insertions(+)
>  create mode 100644 drivers/video/bridge/ssd2825.c
>

[..]

> +static int ssd2825_spi_write(struct udevice *dev, int reg,
> +                            const void *buf, int flags)
> +{
> +       struct spi_slave *slave = dev_get_parent_priv(dev);
> +       u8 command[2];
> +
> +       if (flags & SSD2825_CMD_SEND) {
> +               command[0] = SSD2825_CMD_MASK;
> +               command[1] = reg;
> +               spi_xfer(slave, 9, &command,
> +                        NULL, SPI_XFER_ONCE);

Please can you use dm_spi_xfer() instead, thoughout?

Also note that when you add a printf() for errors, the string is
stored and it increases code size. It might be better to use
log_debug(), unless the errors are likely.

[..]

Regards,
Simon