[PATCH v3 1/2] ARM: dts: rk3588-rock-5b-u-boot: add bootph-all to pinctrl for sdmmc

Kever Yang kever.yang at rock-chips.com
Thu Apr 20 08:54:21 CEST 2023


On 2023/4/17 18:06, Eugen Hristev wrote:
> To be able to initialize the pinctrl correctly at SPL level and read
> u-boot proper from SD-Card, the pinctrl must be initialized.
>
> Signed-off-by: Eugen Hristev <eugen.hristev at collabora.com>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever

> ---
> Changes in v3:
> - change to bootph-all props.
>
> Changes in v2:
> - add u-boot,dm-spl to pull up nodes, to also setup the pull control
> correctly. Also, in the loop that initializes multiple pins, only the
> first will be muxed as the loop will break when the pull up node is not
> found.
>
>   arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 26 +++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> index 1e87854acd6d..091b036707a8 100644
> --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> @@ -38,6 +38,8 @@
>   };
>   
>   &pinctrl {
> +	bootph-all;
> +
>   	usb {
>   		vcc5v0_host_en: vcc5v0-host-en {
>   			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> @@ -45,6 +47,30 @@
>   	};
>   };
>   
> +&pcfg_pull_up_drv_level_2 {
> +	bootph-all;
> +};
> +
> +&pcfg_pull_up {
> +	bootph-all;
> +};
> +
> +&sdmmc_bus4 {
> +	bootph-all;
> +};
> +
> +&sdmmc_clk {
> +	bootph-all;
> +};
> +
> +&sdmmc_cmd {
> +	bootph-all;
> +};
> +
> +&sdmmc_det {
> +	bootph-all;
> +};
> +
>   &usb_host0_ehci {
>   	companion = <&usb_host0_ohci>;
>   	phys = <&u2phy2_host>;


More information about the U-Boot mailing list