[PATCH 1/1] tools: fix TestFdtUtil()
Heinrich Schuchardt
heinrich.schuchardt at canonical.com
Thu Apr 20 20:03:43 CEST 2023
Variable old_outdir cannot be used before assignment.
The assignment must occur before the try block.
tools/dtoc/test_fdt.py:796:26:
E0601: Using variable 'old_outdir' before assignment
(used-before-assignment)
Add missing space in assignment.
Fixes: a004f29464d1 ("binman: Tidy up _SetupDtb() to use its own temporary file")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
tools/dtoc/test_fdt.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/dtoc/test_fdt.py b/tools/dtoc/test_fdt.py
index 32fa69cbb0..4fe8d12c40 100755
--- a/tools/dtoc/test_fdt.py
+++ b/tools/dtoc/test_fdt.py
@@ -784,8 +784,8 @@ class TestFdtUtil(unittest.TestCase):
def test_ensure_compiled_tmpdir(self):
"""Test providing a temporary directory"""
+ old_outdir = tools.outdir
try:
- old_outdir = tools.outdir
tools.outdir= None
tmpdir = tempfile.mkdtemp(prefix='test_fdt.')
dtb = fdt_util.EnsureCompiled(find_dtb_file('dtoc_test_simple.dts'),
@@ -793,7 +793,7 @@ class TestFdtUtil(unittest.TestCase):
self.assertEqual(tmpdir, os.path.dirname(dtb))
shutil.rmtree(tmpdir)
finally:
- tools.outdir= old_outdir
+ tools.outdir = old_outdir
def test_get_phandle_name_offset(self):
val = fdt_util.GetPhandleNameOffset(self.node, 'missing')
--
2.39.2
More information about the U-Boot
mailing list