[PATCH v9 8/9] rockchip: Move to standard boot
Simon Glass
sjg at chromium.org
Mon Apr 24 03:50:05 CEST 2023
Hi Tom,
On Mon, 24 Apr 2023 at 11:35, Tom Rini <trini at konsulko.com> wrote:
>
> On Sun, Apr 23, 2023 at 10:46:27PM +0000, Jonas Karlman wrote:
> > Hi Simon,
> >
> > On 2023-04-08 22:44, Simon Glass wrote:
> > > Drop the distro-boot scripts and use standard boot instead.
> >
> > With the "Drop patches which enable BOOTSTD_DEFAULT" in v9 we must imply
> > BOOTSTD_DEFAULTS or we run into the following on anything rk not rk3399.
> >
> > ## Error: "distro_bootcmd" not defined
> >
> > Something like this was needed to get my devices booting using bootflow:
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1956,8 +1956,7 @@ config ARCH_ROCKCHIP
> > imply ADC
> > imply CMD_DM
> > imply DEBUG_UART_BOARD_INIT
> > - imply DISTRO_DEFAULTS if !ROCKCHIP_RK3399
> > - imply BOOTSTD_DEFAULTS if !DISTRO_DEFAULTS
> > + imply BOOTSTD_DEFAULTS
> > imply FAT_WRITE
> > imply SARADC_ROCKCHIP
> > imply SPL_SYSRESET
> >
> > With above fixed,
> >
> > Tested-by: Jonas Karlman <jonas at kwiboo.se>
> >
> > using basic distro boot on following devices:
> > - RK3288: TinkerBoard R2.0
> > - RK3328: Rock64
> > - RK3399: Rock Pi 4B+
> > - RK3568: Rock 3A
> > - RK3588: Rock 5B
>
> Yup, that indeed is missing. Can you please fold that in somewhere and
> re-spin Simon? And perhaps a u-boot-initial-env loop on all the rockchip
> platforms to make sure the environment is right, in the end? Thanks.
Thank you for testing, Jonas,
I'll add that fix and send v10. With that only evb-rv1108 has a
bootcmd that isn't 'bootflow scan', since it has a custom command.
Regards,
Simon
More information about the U-Boot
mailing list