[PATCH v2 00/30] ide: Clean up code and fix a few bugs
Simon Glass
sjg at chromium.org
Tue Apr 25 18:54:25 CEST 2023
This code was converted to driver model a long time again but it was a
pretty rough conversion. It introduced a few minor bugs, e.g. the device
capacity is incorrect and some flags are lost (such as lba48).
This series tidies up the code and fixes these bugs. This involves quite
a bit of refactoring, so it is done one patch at a time for easier
review.
Changes in v2:
- Drop [] in patch subject
- Rebase to master
Simon Glass (30):
ide: Move ATA_CURR_BASE to C file
ide: Use mdelay() for long delays
ide: Drop CONFIG_START_IDE
ide: Drop init for not using BLK
ide: Move ide_init() into probing
ide: Drop ide_device_present()
ide: Move a few functions further up the file
ide: Drop weak functions
ide: Create a prototype for ide_set_reset()
ide: Correct use of ATAPI
ide: Make function static
ide: Change the retries variable
ide: Refactor confusing loop code
ide: Simplify success condition
ide: Avoid preprocessor for CONFIG_ATAPI
ide: Avoid preprocessor for CONFIG_LBA48
ide: Move bus init into a function
ide: Make ide_bus_ok a local variable
ide: Move setting of vendor strings into ide_probe()
ide: Move ide_init() entirely within ide_probe()
ide: Combine the two loops in ide_probe()
ide: Use desc consistently for struct blk_desc
ide: Make ide_ident() return an error code
ide: Move all blk_desc init into ide_ident()
ide: Use a single local blk_desc for ide_ident()
ide: Correct LBA setting
ide: Tidy up ide_reset()
ide: Convert to use log_debug()
ide: Simplify expressions and hex values
ide: Make use of U-Boot types
cmd/ide.c | 22 +-
common/board_r.c | 17 -
drivers/block/ide.c | 841 ++++++++++++++++++++------------------------
include/blk.h | 5 +-
include/ide.h | 48 +--
test/boot/bootdev.c | 2 -
6 files changed, 415 insertions(+), 520 deletions(-)
--
2.40.0.634.g4ca3ef3211-goog
More information about the U-Boot
mailing list