[PATCH v2] cosmetic:fix typo in 'mmc write' example

Heinrich Schuchardt xypron.glpk at gmx.de
Thu Apr 27 07:24:22 CEST 2023


On 4/26/23 13:05, Shirokov Alexander wrote:
> On Tue, Apr 25, 2023 at 8:01 PM Simon Glass <sjg at chromium.org> wrote:
>
>>> --- a/doc/usage/cmd/mmc.rst
>>> +++ b/doc/usage/cmd/mmc.rst
>>> @@ -216,7 +216,7 @@ The raw data can be read/written via 'mmc
>> read/write' command:
>>>       => mmc read 0x40000000 0x5000 0x100
>>>       MMC read: dev # 0, block # 20480, count 256 ... 256 blocks read: OK
>>>
>>> -    => mmc write 0x40000000 0x5000 0x10
>>> +    => mmc write 0x40000000 0x5000 100
>>
>> Drop the other 0x things too?
>>
>>>       MMC write: dev # 0, block # 20480, count 256 ... 256 blocks
>> written: OK
>>>
>>
>> Regards,
>> Simon
>>
>
> Hi Simon,
> Sure. I'll do that. But one clarification before. Should I change 0x only in
> "mmc write" line or change "mmc read" too, to keep the example consistent?
>

Please, keep the document consistent. do_mmc_read() uses hextoul(). So
it is safe to remove the 0x prefixes in the mmc read example too.

Best regards

Heinrich

Best regards

Heinrich


More information about the U-Boot mailing list