[PATCH] arm: imx8m: remove unused and obsolete board_fix_fdt() in SOC context

Fabio Estevam festevam at gmail.com
Thu Apr 27 20:37:01 CEST 2023


Hi Hugo,

On Tue, Apr 25, 2023 at 11:20 AM Hugo Villeneuve <hugo at hugovil.com> wrote:
>
> From: Hugo Villeneuve <hvilleneuve at dimonoff.com>
>
> It doesn't seem appropriate for arch/SOC to use a board-level
> functionality (CONFIG_OF_BOARD_FIXUP), because this prevents boards
> that need to do FDT fixup from using that feature.
>
> Also, this code is completely dead and useless (from comments by
> Rasmus Villemoes on the mailing list):
>
>   - No in-tree imx8m-based board seems to set CONFIG_OF_BOARD_FIXUP
>   - The nodes which that function wants to disable don't even exist in
>     the U-Boot copy of imx8mp.dtsi.
>
> This code was introduced in commit 35bb60787b88. It seems to be some
> random import of code from downstream NXP U-Boot, with a commit
> message that makes no sense in upstream context.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve at dimonoff.com>

Reviewed-by: Fabio Estevam <festevam at denx.de>


More information about the U-Boot mailing list