[PATCH] env: Remove misuse of env is nowhere driver

[Heiko Schocher]

Hello Stefan,

On 28.04.23 15:45, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> 
> When using a list of writeable variables, the initial values come from
> the built-in default environment since commit 5ab81058364b
> ("env: Complete generic support for writable list"). Remove unnecessary
> misuse of the env is nowhere driver as default environment.
> 
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> ---
> 
>  board/aristainetos/aristainetos.c    | 19 -------------------
>  configs/aristainetos2c_defconfig     |  1 -
>  configs/aristainetos2ccslb_defconfig |  1 -
>  env/env.c                            |  2 --
>  4 files changed, 23 deletions(-)

NACK.

You completely break the protected environment functionality
for the aristainetos board when you remove env_get_location()

Does it build anymore?

Also you mix up a change in common code and in board code.

And grepping in code for ENVL_NOWHERE has much more finds...

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de