[PATCH 3/3] efi: Correct .efi rules

[Heinrich Schuchardt]

Am 30. April 2023 03:21:47 MESZ schrieb Simon Glass <sjg at chromium.org>:
>These files should have both 'always' and 'targets' so that dependencies
>are detected correctly.
>
>When only 'always' is used, the target is built every time, although I am
>not quite sure why.
>
>Make sure each has both 'always' and 'targets' to avoid this problem.
>
>Signed-off-by: Simon Glass <sjg at chromium.org>
>---
>
> lib/efi_loader/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
>index 13a35eae6c06..1a8c8d7cab5c 100644
>--- a/lib/efi_loader/Makefile
>+++ b/lib/efi_loader/Makefile

How about lib/efi_selftest/Makefile? Any changes needed there too?

Best regards

Heinrich


>@@ -23,6 +23,7 @@ CFLAGS_REMOVE_initrddump.o := $(CFLAGS_NON_EFI)
> 
> ifdef CONFIG_RISCV
> always += boothart.efi
>+targets += boothart.o
> endif
> 
> ifneq ($(CONFIG_CMD_BOOTEFI_HELLO_COMPILE),)
>@@ -32,10 +33,12 @@ endif
> 
> ifeq ($(CONFIG_GENERATE_ACPI_TABLE),)
> always += dtbdump.efi
>+targets += dtbdump.o
> endif
> 
> ifdef CONFIG_EFI_LOAD_FILE2_INITRD
> always += initrddump.efi
>+targets += initrddump.o
> endif
> 
> obj-$(CONFIG_CMD_BOOTEFI_HELLO) += helloworld_efi.o