[PATCH 1/2] drivers: video: tidss: tidss_drv: Change remove method

Devarsh Thakkar devarsht at ti.com
Tue Aug 1 11:47:55 CEST 2023



On 27/07/23 12:01, Jain, Nikhil wrote:
> Change remove method of DSS video driver to disable video port instead
> of performing a soft reset, as soft reset takes longer duration. Video
> port is disabled by setting enable bit of video port to 0.
> 
> Signed-off-by: Nikhil M Jain <n-jain1 at ti.com>

Reviewed-by: Devarsh Thakkar <devarsht at ti.com>

> ---
>  drivers/video/tidss/tidss_drv.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/video/tidss/tidss_drv.c b/drivers/video/tidss/tidss_drv.c
> index 078e3e82e3..623bf4cf31 100644
> --- a/drivers/video/tidss/tidss_drv.c
> +++ b/drivers/video/tidss/tidss_drv.c
> @@ -901,19 +901,9 @@ static int tidss_drv_probe(struct udevice *dev)
>  
>  static int tidss_drv_remove(struct udevice *dev)
>  {
> -	u32 val;
> -	int ret;
>  	struct tidss_drv_priv *priv = dev_get_priv(dev);
>  
> -	priv->base_common = dev_remap_addr_index(dev, 0);
> -	REG_FLD_MOD(priv, DSS_SYSCONFIG, 1, 1, 1);
> -	/* Wait for reset to complete */
> -	ret = readl_poll_timeout(priv->base_common + DSS_SYSSTATUS,
> -				 val, val & 1, 5000);
> -	if (ret) {
> -		dev_warn(priv->dev, "failed to reset priv\n");
> -		return ret;
> -	}
> +	VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0);
>  	return 0;
>  }
>  


More information about the U-Boot mailing list