[PATCH 0/6] rockchip: rk3568: Fix use of PCIe bifurcation

[John Clark]

It appears that you had a transmission problem with this patch as I am 
missing 1/6, 4/6, and 6/6.

I am pretty sure these are from your repo here: 
https://github.com/Kwiboo/u-boot-rockchip/tree/rk35xx-pcie-bifurcation-v1

(1/6) pci: pcie_dw_rockchip: Configure number of lanes and link width speed
https://github.com/Kwiboo/u-boot-rockchip/commit/2b3f591aec3abe69adc9bbc723d98550ecce3614

(2/6) phy: rockchip: snps-pcie3: Refactor to use clk_bulk API
https://github.com/Kwiboo/u-boot-rockchip/commit/e6c561d1e00b92e1d4c98f9ce581385d601dbc4c

(3/6) phy: rockchip: snps-pcie3: Refactor to use a phy_init ops
https://github.com/Kwiboo/u-boot-rockchip/commit/627648f509f149ac9b0ade84c2a863e62b15d0a7

(4/6) phy: rockchip: snps-pcie3: Add bifurcation support for RK3568
https://github.com/Kwiboo/u-boot-rockchip/commit/a8d3342b986df42191793e2d0f72df2f41e8adff

(5/6) phy: rockchip: snps-pcie3: Add support for RK3588
https://github.com/Kwiboo/u-boot-rockchip/commit/031df04ac14b3ddaba7f3be07f9a78898b73d0a5

(6/6) rockchip: rk3568-radxa-e25: Enable pcie3x1 node
https://github.com/Kwiboo/u-boot-rockchip/commit/4439243b10731067baf64ea6bff84ac0519fe6d7

These work for me and detect a Nanopi R5S NVMe.  Can you resend this 
patchset so I can definitively confirm?  It would be great if this can 
be fixed in 2023.10.


Thanks,

John Clark


On 8/1/23 5:25 PM, Jonas Karlman wrote:
> This series add support for use of PCIe bifurcation on RK3568, and as a
> bonus support for the RK3588 PHY is also included. With PCIe bifurcation
> supported it is possible to enable PCIe on more RK3568 boards, e.g. on
> NanoPi R5C and NanoPi R5S. This series only include fixing the mini PCIe
> slot on Radxa E25.
>
> Most parts of this series was imported almost 1:1 from mainline linux.
>
> Patch 1 fixes configuration of number of lanes in pcie_dw_rockchip.
> Patch 2-3 refactor the snps-pcie3 phy driver.
> Patch 4 add bifurcation support for RK3568.
> Patch 5 add support for RK3588.
> Patch 6 enables the mini PCIe slot on Radxa E25.
>
> The RK3588 PHY part was tested on a ROCK 5B together with device tree
> files picked from Sebastian Reichel's rk3588 branch at [1].
>
> Patches in this series is also aviliable at [2].
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-misc.git/tree/?h=rk3588
> [2] https://github.com/Kwiboo/u-boot-rockchip/commits/rk35xx-pcie-bifurcation-v1
>
> Jonas Karlman (6):
>    pci: pcie_dw_rockchip: Configure number of lanes and link width speed
>    phy: rockchip: snps-pcie3: Refactor to use clk_bulk API
>    phy: rockchip: snps-pcie3: Refactor to use a phy_init ops
>    phy: rockchip: snps-pcie3: Add bifurcation support for RK3568
>    phy: rockchip: snps-pcie3: Add support for RK3588
>    rockchip: rk3568-radxa-e25: Enable pcie3x1 node
>
>   arch/arm/dts/rk3568-radxa-e25-u-boot.dtsi     |  11 +-
>   configs/radxa-e25-rk3568_defconfig            |   1 -
>   drivers/pci/pcie_dw_rockchip.c                |  58 ++++-
>   .../phy/rockchip/phy-rockchip-snps-pcie3.c    | 230 ++++++++++++++----
>   4 files changed, 235 insertions(+), 65 deletions(-)
>