[PATCH] usb: xhci: pet watchdog during transfers

Marek Vasut marex at denx.de
Fri Aug 4 21:11:40 CEST 2023


On 8/4/23 21:00, seanedmond at linux.microsoft.com wrote:
> From: Godfrey Mwangi <godmwan at microsoft.com>
> 
> On some platforms with low USB throughput, tranfers
> of huge files take a long time and watchdog timer can
> expire resulting in hardware reset. Avoid this by
> petting the watchdog as long as we have pending transfers.
> 
> Signed-off-by: Godfrey Mwangi <godmwan at microsoft.com>
> ---
>   drivers/usb/host/xhci-ring.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index c8260cbdf9..de954314bc 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -18,6 +18,7 @@
>   #include <log.h>
>   #include <asm/byteorder.h>
>   #include <usb.h>
> +#include <watchdog.h>
>   #include <asm/unaligned.h>
>   #include <linux/bug.h>
>   #include <linux/errno.h>
> @@ -758,6 +759,8 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long pipe,
>   		/* Calculate length for next transfer */
>   		addr += trb_buff_len;
>   		trb_buff_len = min((length - running_total), TRB_MAX_BUFF_SIZE);
> +
> +		schedule();
>   	} while (running_total < length);
>   
>   	giveback_first_trb(udev, ep_index, start_cycle, start_trb);

s at pet@ping@ or trigger .

With that fixed:

Reviewed-by: Marek Vasut <marex at denx.de>

Thanks !


More information about the U-Boot mailing list