[PATCH 3/5] clk: rockchip: rk3568: Include UART clocks in SPL

Jonas Karlman jonas at kwiboo.se
Sat Aug 5 13:16:48 CEST 2023

On 2023-08-04 12:05, Eugen Hristev wrote:
> On 8/4/23 12:33, Jonas Karlman wrote:
>> The clock driver for RK3568 does not include support for UART clocks in
>> SPL. This result in the following message with high enough loglevel.
>>    ns16550_serial serial at fe660000: pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19

The change to include UART clocks in SPL does not fix above warning
message. Instead the patch at [1] fixes this warning.

This change is however fixing that the ns16550_serial can get the UART
clock rate from clock instead of falling back on clock-frequency
property in DT. Will re-spin with an updated commit message.

[1] https://patchwork.ozlabs.org/project/uboot/patch/20230805111041.750550-1-jonas@kwiboo.se/


>> Fix this by including support for UART clocks in SPL.
>> Fixes: 4a262feba3a5 ("rockchip: rk3568: add clock driver")
>> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
>> ---
> Something like this it's also done for the 3588, and I still have not 
> figured out why. When the rk3588 clock driver was added, I commented on 
> this, but the result was just that the 'clock not found' message was 
> removed.
> I am happy that you found some time to do these changes
> Reviewed-by: Eugen Hristev <eugen.hristev at collabora.com>

More information about the U-Boot mailing list