[PATCH 5/5] rockchip: rk356x-u-boot: Set max-frequency prop in sdhci node

Kever Yang kever.yang at rock-chips.com
Mon Aug 7 02:48:29 CEST 2023


On 2023/8/4 17:34, Jonas Karlman wrote:
> Most board device trees for RK356x set max-frequency = <200000000> in
> the sdhci node, some boards like Quartz64 do not. This result in an
> error message due to sdhci driver trying to set a clock rate of 0
> instead of the max-frequency value.
>
>    rockchip_sdhci_probe clk set rate fail!
>
> Fix this by setting a common max-frequency in rk356x-u-boot.dtsi. A
> patch to set default max-frequency of sdhci node in linux is planned.
>
> Also remove the forced status = "okay" for the sdhci and sdmmc0 nodes,
> boards already set correct state for these nodes.
>
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk356x-u-boot.dtsi | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/rk356x-u-boot.dtsi b/arch/arm/dts/rk356x-u-boot.dtsi
> index d21b18205220..32f687f2924b 100644
> --- a/arch/arm/dts/rk356x-u-boot.dtsi
> +++ b/arch/arm/dts/rk356x-u-boot.dtsi
> @@ -126,12 +126,11 @@
>   
>   &sdhci {
>   	bootph-pre-ram;
> -	status = "okay";
> +	max-frequency = <200000000>;
>   };
>   
>   &sdmmc0 {
>   	bootph-pre-ram;
> -	status = "okay";
>   };
>   
>   #ifdef CONFIG_ROCKCHIP_SPI_IMAGE


More information about the U-Boot mailing list