[PATCH v5 2/2] board: mediatek: add mt8195 demo board
Michael Walle
mwalle at kernel.org
Mon Aug 7 08:59:47 CEST 2023
Hi,
> + printf("Disabling WDT\n");
> + writel(0, 0x10007000);
Please don't use magic numbers. Also, I guess this should be a
real watchdog driver and u-boot will take care of disabling it
if the user wants to.
> +
> + printf("Enabling SCP SRAM\n");
> + for (unsigned int val = 0xFFFFFFFF; val != 0U;) {
> + val = val >> 1;
> + writel(val, 0x1072102C);
Even more magic numbers.
> + }
Thanks,
-michael
More information about the U-Boot
mailing list