[PATCH 18/28] moveconfig: Only show output when there is a reason
Simon Glass
sjg at chromium.org
Thu Aug 10 18:31:50 CEST 2023
There is no point in listing a board if everything went well. It makes it
harder to see the failures, particularly on a fast machine.
Suppress output unless something actually happened.
Drop the 'Syncing by savedefconfig' since this is selected by the -s and
is the same for all boards in this mode.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
tools/moveconfig.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/moveconfig.py b/tools/moveconfig.py
index 816eb151bdf..08ff82a4c02 100755
--- a/tools/moveconfig.py
+++ b/tools/moveconfig.py
@@ -551,7 +551,6 @@ class Slot:
if not self.args.force_sync:
self.finish(True)
return
- self.log += 'Syncing by savedefconfig (forced by option)...\n'
cmd = list(self.make_cmd)
cmd.append('savedefconfig')
@@ -581,12 +580,13 @@ class Slot:
successfully, or False when it fails.
"""
# output at least 30 characters to hide the "* defconfigs out of *".
- log = self.defconfig.ljust(30) + '\n'
+ if self.log:
+ log = self.defconfig.ljust(30) + '\n'
- log += '\n'.join([ ' ' + s for s in self.log.split('\n') ])
- # Some threads are running in parallel.
- # Print log atomically to not mix up logs from different threads.
- print(log, file=(sys.stdout if success else sys.stderr))
+ log += '\n'.join([ ' ' + s for s in self.log.split('\n') ])
+ # Some threads are running in parallel.
+ # Print log atomically to not mix up logs from different threads.
+ print(log, file=(sys.stdout if success else sys.stderr))
if not success:
if self.args.exit_on_error:
--
2.41.0.640.ga95def55d0-goog
More information about the U-Boot
mailing list