[PATCH 2/2] rockchip: rk356x-u-boot: Add bootph-all to i2c0_xfer pinctrl node

[Jonas Karlman]

Hi Quentin,

On 2023-08-08 11:55, Quentin Schulz wrote:
> Hi Jonas,
> 
> On 8/3/23 23:11, Jonas Karlman wrote:
>> A RK8XX PMIC is typically using i2c0 on RK356x devices. Add bootph-all
>> to required pinctrl nodes to simplify use of the prevent booting on
>> power plug-in option in SPL.
>>
> 
> I'd say this should be added to device-specific DTSes whenever 
> appropriate and not to the SoC-specific DTSI. Not everybody's following 
> to the letter the reference design. This also unnecessarily increases 
> the size of the SPL DTSes for boards which aren't following the 
> reference design.

This only help ensures that the default pinctrl defined in rk356x.dtsi
for i2c0 would be included in SPL dtb when the i2c0 node is enabled.

The size change is negligible, my Pine64 Quartz64-A u-boot-spl.dtb
increase 185 bytes, from 5392 to 5577. And with u-boot-spl.bin at 139 KB
SPL can grow an additional 117 KB until we reach size limit.

I mainly wanted to remove the need for duplicate definition in board
u-boot.dtsi for upcoming devices like Pine64 PineNote and PineTab2.

Regards,
Jonas

> 
> Cheers,
> Quentin