[PATCH 1/2] rockchip: spl: Drop useless call to debug_uart_init

Kever Yang kever.yang at rock-chips.com
Sat Aug 12 04:36:42 CEST 2023


On 2023/8/3 01:05, Massimo Pegorer wrote:
> Since commit 0dba45864b2a ("arm: Init the debug UART") function
> debug_uart_init is called in crt files _main before calling
> board_init_f. Therefore, there is no need to call it again
> inside board_init_f implementation in arm/mach-rockchip/spl.c.
>
> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss at gmail.com>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/mach-rockchip/spl.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c
> index 30be640425..a6396b3c42 100644
> --- a/arch/arm/mach-rockchip/spl.c
> +++ b/arch/arm/mach-rockchip/spl.c
> @@ -116,12 +116,10 @@ void board_init_f(ulong dummy)
>   	/*
>   	 * Debug UART can be used from here if required:
>   	 *
> -	 * debug_uart_init();
>   	 * printch('a');
>   	 * printhex8(0x1234);
>   	 * printascii("string");
>   	 */
> -	debug_uart_init();
>   	debug("\nspl:debug uart enabled in %s\n", __func__);
>   #endif
>   


More information about the U-Boot mailing list