[PATCH 1/1] common: return type board_get_usable_ram_top

[Tom Rini]

On Mon, Aug 14, 2023 at 08:31:31AM +0200, Heinrich Schuchardt wrote:
> 
> 
> On 8/13/23 15:36, Simon Glass wrote:
> > Hi Heinrich,
> > 
> > On Sat, 12 Aug 2023 at 23:01, Heinrich Schuchardt
> > <heinrich.schuchardt at canonical.com> wrote:
> > > 
> > > board_get_usable_ram_top() returns a physical address that is stored in
> > > gd->ram_top. The return type of the function should be phys_addr_t like the
> > > current type of gd->ram_top.
> > > 
> > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > > ---
> > >   arch/arm/mach-imx/imx8m/soc.c           | 2 +-
> > >   arch/arm/mach-mvebu/arm64-common.c      | 2 +-
> > >   arch/arm/mach-rockchip/sdram.c          | 2 +-
> > >   arch/arm/mach-stm32mp/dram_init.c       | 2 +-
> > >   arch/arm/mach-sunxi/board.c             | 2 +-
> > >   arch/arm/mach-tegra/board2.c            | 2 +-
> > >   arch/mips/mach-jz47xx/jz4780/jz4780.c   | 2 +-
> > >   arch/mips/mach-octeon/dram.c            | 2 +-
> > >   arch/riscv/cpu/fu540/dram.c             | 2 +-
> > >   arch/riscv/cpu/fu740/dram.c             | 2 +-
> > >   arch/riscv/cpu/generic/dram.c           | 2 +-
> > >   arch/riscv/cpu/jh7110/dram.c            | 2 +-
> > >   arch/x86/cpu/broadwell/sdram.c          | 2 +-
> > >   arch/x86/cpu/coreboot/sdram.c           | 2 +-
> > >   arch/x86/cpu/efi/payload.c              | 2 +-
> > >   arch/x86/cpu/efi/sdram.c                | 2 +-
> > >   arch/x86/cpu/ivybridge/sdram.c          | 2 +-
> > >   arch/x86/cpu/qemu/dram.c                | 2 +-
> > >   arch/x86/cpu/quark/dram.c               | 2 +-
> > >   arch/x86/cpu/slimbootloader/sdram.c     | 2 +-
> > >   arch/x86/cpu/tangier/sdram.c            | 2 +-
> > >   arch/x86/include/asm/u-boot-x86.h       | 2 +-
> > >   arch/x86/lib/fsp1/fsp_dram.c            | 2 +-
> > >   arch/x86/lib/fsp2/fsp_dram.c            | 2 +-
> > >   board/broadcom/bcmns3/ns3.c             | 2 +-
> > >   board/imgtec/boston/ddr.c               | 2 +-
> > >   board/menlo/m53menlo/m53menlo.c         | 2 +-
> > >   board/raspberrypi/rpi/rpi.c             | 2 +-
> > >   board/ti/am65x/evm.c                    | 2 +-
> > >   board/ti/j721e/evm.c                    | 2 +-
> > >   board/ti/j721s2/evm.c                   | 2 +-
> > >   board/toradex/verdin-am62/verdin-am62.c | 2 +-
> > >   board/xilinx/common/board.c             | 2 +-
> > >   common/board_f.c                        | 2 +-
> > >   include/init.h                          | 2 +-
> > >   35 files changed, 35 insertions(+), 35 deletions(-)
> > 
> > While you are here, could you please fix the function comment?
> > 
> > [..]
> > 
> > > diff --git a/include/init.h b/include/init.h
> > > index 8873081685..b1e1451166 100644
> > > --- a/include/init.h
> > > +++ b/include/init.h
> > > @@ -304,7 +304,7 @@ int show_board_info(void);
> > >    *
> > >    * @param total_size   Size of U-Boot (unused?)
> > 
> > It seems confused about the param, and we should have a return value.
> 
> The parameter with the monitor length (size of U-Boot code) is not used
> anywhere (though it is passed on to functions like
> mrc_common_board_get_usable_ram_top() where it isn't used either).
> 
> We should try to eliminate the parameter in further patches.
> 
> > 
> > Also should explain what this function is used for.
> 
> That explanation exists.
> 
> I will put the documentation fix into a separate patch so we can apply it to
> 2023.10. I don't know if Tom wants to apply this patch to next or to
> 2023.10.

I'm thinking we should take this for v2023.10.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230814/b167a2c2/attachment.sig>