[PATCH] buildman: Allow more results while building

Tom Rini trini at konsulko.com
Tue Aug 15 22:24:14 CEST 2023


On Tue, Aug 15, 2023 at 12:39:37PM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Tue, 15 Aug 2023 at 08:42, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Thu, Aug 03, 2023 at 12:59:55PM -0600, Simon Glass wrote:
> >
> > > The -v option enables display of build results while building, instead of
> > > needing to do a separate summary step later (or in another terminal). But
> > > this resets the build results after each commit, so that all errors are
> > > reported fresh, without trying to diff them against previous errors
> > > already shown.
> > >
> > > Drop this reset, as an experiment, so see if this is useful.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > >  tools/buildman/builder.py | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
> > > index ecbd368c47a..5ee2b5959b2 100644
> > > --- a/tools/buildman/builder.py
> > > +++ b/tools/buildman/builder.py
> > > @@ -536,7 +536,6 @@ class Builder:
> > >              if self._verbose:
> > >                  terminal.print_clear()
> > >                  boards_selected = {target : result.brd}
> > > -                self.reset_result_summary(boards_selected)
> > >                  self.produce_result_summary(result.commit_upto, self.commits,
> > >                                            boards_selected)
> > >          else:
> >
> > Nope, this doesn't change any of the output I see in how I usually do my
> > world builds.
> 
> For me it allows using -S and -B during the build phase, and seeing some output.
> 
> However, the patch is not correct...it is just a concept. I should
> have marked it as RFC.

Well, take a look at
https://gist.github.com/trini/2e88e94743821586ef742a936c45c389 and if
you can think of things that'll make the output between lines 53 and 458
clearer / smaller that's what I'm looking for.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230815/9b1bf429/attachment.sig>


More information about the U-Boot mailing list