[PATCH v2 1/2] log: select physical address formatting in a generic way

[Marek Vasut]

On 8/16/23 16:39, Simon Glass wrote:
> Hi Marek,
> 
> On Wed, 16 Aug 2023 at 05:13, Marek Vasut <marek.vasut at mailbox.org> wrote:
>>
>> On 8/16/23 13:05, Abdellatif El Khlifi wrote:
>>> sets the log formatting according to the platform (64-bit vs 32-bit)
>>
>> Use imperative mood please, see
>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
>>
>>> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> ---
>>>    cmd/armffa.c  | 8 --------
>>>    include/log.h | 9 +++++++++
>>>    2 files changed, 9 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/cmd/armffa.c b/cmd/armffa.c
>>> index 7e6eafc03a..ab0fd54d97 100644
>>> --- a/cmd/armffa.c
>>> +++ b/cmd/armffa.c
>>> @@ -13,14 +13,6 @@
>>>    #include <stdlib.h>
>>>    #include <asm/io.h>
>>>
>>> -/* Select the right physical address formatting according to the platform */
>>> -#ifdef CONFIG_PHYS_64BIT
>>> -#define PhysAddrLength "ll"
>>> -#else
>>> -#define PhysAddrLength ""
>>> -#endif
>>> -#define PHYS_ADDR_LN "%" PhysAddrLength "x"
>>
>> Would it make sense to implement printf '%pa' formatting string instead ?
> 
> The problem is that it is not a pointer. Also we want the compiler to
> check the size.

What does Linux use ?