Re: [PATCH v2 12/20] x86: smbios: Add a Kconfig indicating SMBIOS-table presence

[Heinrich Schuchardt]

Am 18. August 2023 02:26:51 MESZ schrieb Simon Glass <sjg at chromium.org>:
>When booted from coreboot, U-Boot does not build the SMBIOS tables, but
>it should still pass them on to the OS. Add a new option which indicates
>whether SMBIOS tables are present, however they were built.
>
>Flip the ordering so that the dependency is listed first, which is less
>confusing.
>
>Signed-off-by: Simon Glass <sjg at chromium.org>
>---
>
>Changes in v2:
>- Add new patch
>
> lib/Kconfig | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/lib/Kconfig b/lib/Kconfig
>index a9dca5f52b5a..b7bbf3f81c56 100644
>--- a/lib/Kconfig
>+++ b/lib/Kconfig
>@@ -984,8 +984,9 @@ config BLOBLIST_TABLES
> 
> config GENERATE_SMBIOS_TABLE
> 	bool "Generate an SMBIOS (System Management BIOS) table"
>-	default y
> 	depends on X86 || EFI_LOADER
>+	default y
>+	imply SMBIOS

Is there any use case for GENERATE_SMBIOD_TABLE=y and SMBIOS=n?  I would have expected 'depends on SMBIOS' here.

> 	help
> 	  The System Management BIOS (SMBIOS) specification addresses how
> 	  motherboard and system vendors present management information about
>@@ -1054,6 +1055,15 @@ config SPL_OID_REGISTRY
> 	  unambiguous persistent name (https://en.wikipedia.org/wiki/Object_identifier).
> 	  Enable fast lookup object identifier registry in the SPL.
> 
>+config SMBIOS
>+	bool "SMBIOS support"
>+	depends on X86

We need SMBIOS tables on all EFI architectures.

>+	default y
>+	help
>+	  Indicates that this platform can create System Management BIOS

This is very confusing: create and generate are just synonyms. Given this description I would not know what is the difference between the symbols.

Best regards

Heinrich


>+	  (SMBIOS) tables. These provide various pieces of information about
>+	  the board, such as the manufacturer and the model name.
>+
> config SMBIOS_PARSER
> 	bool "SMBIOS parser"
> 	help