[PATCH v4 1/2] musb-new: ti-musb: Handle usb dual-role feature as peripheral

Tom Rini trini at konsulko.com
Mon Aug 21 15:57:44 CEST 2023


On Mon, Aug 21, 2023 at 03:40:42PM +0200, Marek Vasut wrote:
> On 8/21/23 14:16, Roger Quadros wrote:
> > Hi Julien,
> > 
> > On 21/08/2023 11:28, Julien Panis wrote:
> > > On 8/14/23 19:18, Tom Rini wrote:
> > > > On Thu, Jul 06, 2023 at 12:40:22PM +0200, Julien Panis wrote:
> > > > 
> > > > > This prevents from getting some 'No USB device found' error,
> > > > > in usb_ether_init() function for instance.
> > > > > 
> > > > > Signed-off-by: Julien Panis <jpanis at baylibre.com>
> > > > > Reviewed-by: Tony Lindgren <tony at atomide.com>
> > > > > Reviewed-by: Nishanth Menon <nm at ti.com>
> > > > > ---
> > > > >    drivers/usb/musb-new/ti-musb.c | 1 +
> > > > >    1 file changed, 1 insertion(+)
> > > > > 
> > > > > diff --git a/drivers/usb/musb-new/ti-musb.c b/drivers/usb/musb-new/ti-musb.c
> > > > > index 3be3f93dd85d..44697dc31387 100644
> > > > > --- a/drivers/usb/musb-new/ti-musb.c
> > > > > +++ b/drivers/usb/musb-new/ti-musb.c
> > > > > @@ -302,6 +302,7 @@ static int ti_musb_wrapper_bind(struct udevice *parent)
> > > > >            dr_mode = usb_get_dr_mode(node);
> > > > >            switch (dr_mode) {
> > > > >            case USB_DR_MODE_PERIPHERAL:
> > > > > +        case USB_DR_MODE_OTG:
> > > > >                /* Bind MUSB device */
> > > > >                ret = device_bind_driver_to_node(parent,
> > > > >                                 "ti-musb-peripheral",
> > > > Julien, why don't we support OTG mode here instead?
> > > > 
> > > 
> > > Roger, can this be achieved with this controller ?
> > 
> > The Controller supports OTG mode but I'm not sure of the u-boot driver.
> > 
> > Bin / Stephan might know.
> 
> Surely the controller supports both Host and Peripheral mode.

And perhaps the other half of the disconnect here is that DWC2/DWC3 at
least behave in U-Boot as Marek is asking.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230821/5a80b7e1/attachment.sig>


More information about the U-Boot mailing list