[PATCH 1/1] lib: parameter check in hash_calculate

Simon Glass sjg at google.com
Tue Aug 22 20:56:39 CEST 2023


On Tue, 22 Aug 2023 at 02:43, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> If hash_calculate is invoked with region_count = 0, it will try to hash
> INT_MAX regions. We should check this parameter.
>
> * Avoid a comparison with different signedness.
> * Check that region_count is at least 1.
> * Avoid a superfluous assignment.
>
> Fixes: b37b46f042cc ("rsa: Use checksum algorithms from struct hash_algo")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  lib/hash-checksum.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list