[PATCH 06/19] FMU: Avoid showing an unselectable menu option

Sughosh Ganu sughosh.ganu at linaro.org
Fri Aug 25 14:00:17 CEST 2023


On Fri, 25 Aug 2023 at 01:29, Simon Glass <sjg at chromium.org> wrote:
>
> Use a menuconfig to avoid showing a menu which cannot be selected in many
> cases.
>
> This option should really go with the other 'Update support'.
>
> Perhaps we should even consider a top-level update/ directory?
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---

nit: s/FMU/FWU in the commit header.

Acked-by: Sughosh Ganu <sughosh.ganu at linaro.org>

-sughosh

>
>  lib/Kconfig             | 4 ----
>  lib/fwu_updates/Kconfig | 6 +++++-
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 9addcfab3734..bfab2f3165a7 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -1118,8 +1118,4 @@ config PHANDLE_CHECK_SEQ
>
>  endmenu
>
> -menu "FWU Multi Bank Updates"
> -
>  source lib/fwu_updates/Kconfig
> -
> -endmenu
> diff --git a/lib/fwu_updates/Kconfig b/lib/fwu_updates/Kconfig
> index 71f34793d926..be35ad29fa32 100644
> --- a/lib/fwu_updates/Kconfig
> +++ b/lib/fwu_updates/Kconfig
> @@ -1,4 +1,4 @@
> -config FWU_MULTI_BANK_UPDATE
> +menuconfig FWU_MULTI_BANK_UPDATE
>         bool "Enable FWU Multi Bank Update Feature"
>         depends on EFI_CAPSULE_ON_DISK
>         select PARTITION_TYPE_GUID
> @@ -10,6 +10,8 @@ config FWU_MULTI_BANK_UPDATE
>           multiple banks(copies) of the firmware images. One of the
>           bank is selected for updating all the firmware components
>
> +if FWU_MULTI_BANK_UPDATE
> +
>  config FWU_NUM_BANKS
>         int "Number of Banks defined by the platform"
>         depends on FWU_MULTI_BANK_UPDATE
> @@ -31,3 +33,5 @@ config FWU_TRIAL_STATE_CNT
>           With FWU Multi Bank Update feature enabled, number of times
>           the platform is allowed to boot in Trial State after an
>           update.
> +
> +endif
> --
> 2.42.0.rc1.204.g551eb34607-goog
>


More information about the U-Boot mailing list