[PATCH] clk: Dont return error when assigned-clocks is empty or missing

[Tom Rini]

On Fri, Aug 25, 2023 at 09:15:09AM +0200, Michal Simek wrote:
> Hi Tom,
> 
> On 7/11/23 11:51, Ashok Reddy Soma wrote:
> > There is a chance that assigned-clock-rates is given and assigned-clocks
> > could be empty. Dont return error in that case, because the probe of the
> > corresponding driver will not be called at all if this fails.
> > Better to continue to look for it and return 0.
> > 
> > Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> > ---
> > 
> >   drivers/clk/clk-uclass.c | 8 +++++++-
> >   1 file changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
> > index dc3e9d6a26..f186fcbcdb 100644
> > --- a/drivers/clk/clk-uclass.c
> > +++ b/drivers/clk/clk-uclass.c
> > @@ -329,7 +329,13 @@ static int clk_set_default_rates(struct udevice *dev,
> >   			dev_dbg(dev,
> >   				"could not get assigned clock %d (err = %d)\n",
> >   				index, ret);
> > -			continue;
> > +			/* Skip if it is empty */
> > +			if (ret == -ENOENT) {
> > +				ret = 0;
> > +				continue;
> > +			}
> > +
> > +			return ret;
> >   		}
> >   		/* This is clk provider device trying to program itself
> 
> What's your take on this one?  I didn't get reply from Sean.

I guess, what's the validated upstream dts where this is the case?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230825/e708e520/attachment.sig>