[PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain

Simon Glass sjg at chromium.org
Fri Aug 25 20:06:06 CEST 2023


Hi Andy,

On Fri, 25 Aug 2023 at 07:52, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> The Simon's patch missed the FADT to be added to the chain, hence all
> the issues on Intel Tangier.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
>  arch/x86/cpu/tangier/acpi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/tangier/acpi.c
> index 01b30553818c..ffaa56ab6f87 100644
> --- a/arch/x86/cpu/tangier/acpi.c
> +++ b/arch/x86/cpu/tangier/acpi.c
> @@ -52,6 +52,8 @@ static int tangier_write_fadt(struct acpi_ctx *ctx,
>
>         header->checksum = table_compute_checksum(fadt, header->length);
>
> +       acpi_add_table(ctx, fadt);
> +
>         acpi_inc(ctx, sizeof(struct acpi_fadt));
>
>         return 0;
> --
> 2.40.0.1.gaa8946217a0b
>

Thank you! I really don't know how I missed that, after starting at it
all for an hour...

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list