[PATCH v2 2/6] arm: mach-tegra: enable sysreset driver

[Svyatoslav Ryhel]

нд, 27 серп. 2023 р. о 11:21 Svyatoslav Ryhel <clamor95 at gmail.com> пише:
>
> Signed-off-by: Svyatoslav Ryhel <clamor95 at gmail.com>
> ---
>  arch/arm/mach-tegra/Kconfig | 3 +++
>  arch/arm/mach-tegra/pmc.c   | 9 ---------
>  2 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> index 464bd0798f..453f94bcf2 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -61,6 +61,9 @@ config TEGRA_COMMON
>         select MISC
>         select OF_CONTROL
>         select SPI
> +       select SYSRESET
> +       select SPL_SYSRESET
> +       select SYSRESET_TEGRA
>         imply CMD_DM
>         imply CRC32_VERIFY

Hello, Thierry! This causes buildman warnings on aarch64 (t184 and t210)

+ WARNING: unmet direct dependencies detected for SPL_SYSRESET
+  Depends on [n]: SYSRESET [=y] && SPL_DM [=n]
+  Selected by [y]:
+  - TEGRA_COMMON [=y] && ARM [=y] && ARCH_TEGRA [=y]
   aarch64:  w+   p2771-0000-000

It lacks SPL_DM and since aarch64 is your main area of maintenance, may
you help setting it in a way which does not break anything from aarch64
perspective?

Context is next: I am trying to convert tegra PMC reset ability to DM sysreset
driver. Reason is to be able to use do_poweroff in DM sysreset form and it
stated that OR both do_reset and do_poweroff are in DM driver form or none.
Assume at some point this convertation will be requested anyway, like with
timer driver.

> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
> index 8d617bee63..c4f5106750 100644
> --- a/arch/arm/mach-tegra/pmc.c
> +++ b/arch/arm/mach-tegra/pmc.c
> @@ -84,12 +84,3 @@ void tegra_pmc_writel(u32 value, unsigned long offset)
>
>         writel(value, NV_PA_PMC_BASE + offset);
>  }
> -
> -void reset_cpu(void)
> -{
> -       u32 value;
> -
> -       value = tegra_pmc_readl(PMC_CNTRL);
> -       value |= PMC_CNTRL_MAIN_RST;
> -       tegra_pmc_writel(value, PMC_CNTRL);
> -}
> --
> 2.39.2
>