[PATCH v2] spl: bootstage: move bootstage_stash before jumping to image

Simon Glass sjg at chromium.org
Tue Aug 29 18:38:26 CEST 2023


Hi Chanho,

On Mon, 28 Aug 2023 at 22:28, Chanho Park <chanho61.park at samsung.com> wrote:
>
> Regarding IH_OS_OPENSBI, IH_OS_LINUX and IH_OS_TEE, there is no chance
> to stash bootstage record because they do not return to SPL after
> jumping to the image.
> Hence, this patch separates the final stage bootstage code into
> spl_bootstage_finish and call the function before jumping to the image.
>
> Signed-off-by: Chanho Park <chanho61.park at samsung.com>
> ---
> Changes from v1
> - Separate the final stage bootstage code into spl_bootstage_finish.
> - As Simon suggests, call the function before jumping to the image.

I think you misunderstood me here. I mean, you cannot jump off
somewhere in your board code. You must change it so it returns
correctly, and the jump happens from spl.c's board_init_r() function.
The way it works is you set up the spl_image structure, then it SPL
jumps to it at the end of the functions.

Regards,
Simon


More information about the U-Boot mailing list