[PATCH] spl: bootstage: move bootstage_stash before jumping to image

Simon Glass sjg at chromium.org
Tue Aug 29 18:38:27 CEST 2023


Hi Chanho,

On Mon, 28 Aug 2023 at 21:46, Chanho Park <chanho61.park at samsung.com> wrote:
>
> Hi Simon,
>
> > -----Original Message-----
> > From: Simon Glass <sjg at chromium.org>
> > Sent: Tuesday, August 29, 2023 2:55 AM
> > To: Chanho Park <chanho61.park at samsung.com>
> > Cc: Nikhil M Jain <n-jain1 at ti.com>; Marek Vasut <marex at denx.de>; u-
> > boot at lists.denx.de
> > Subject: Re: [PATCH] spl: bootstage: move bootstage_stash before jumping
> > to image
> >
> > Hi Chanho,
> >
> > On Mon, 28 Aug 2023 at 03:46, Chanho Park <chanho61.park at samsung.com>
> > wrote:
> > >
> > > For IH_OS_OPENSBI and IH_OS_LINUX, there is no chance to stash
> > > bootstare record because it will not return after jumping to the image.
> > > Hence, this patch moves the location of bootstage_stash before jumping
> > > to image.
> > >
> >
> > Please fix your implementation instead. You must jump to the OS at the end
> > of this function and not before.
>
> In case of OS_TEE/OPENSBI/LINUX images, they will not be returned to SPL so they can't get a chance to stash boot stage records.
>
> >
> > In fact I have a patch to move bootstage later in this function!
>
> Will you post the patch soon? Or it was already posted?

Not posted yet. I'll reply on your new patch.

Regards,
Simon


More information about the U-Boot mailing list