[PATCH v2 03/19] video: Hide the BMP options

[Tom Rini]

On Thu, Aug 31, 2023 at 09:58:46AM -0400, Tom Rini wrote:
> On Thu, Aug 31, 2023 at 06:05:22AM +0200, Heinrich Schuchardt wrote:
> > 
> > 
> > Am 31. August 2023 05:52:57 MESZ schrieb Simon Glass <sjg at chromium.org>:
> > >These appear prominently in the main menu at present. However they are
> > >selected when needed so do not need to be visible.
> > >
> > >Make them hidden.
> > >
> > >Signed-off-by: Simon Glass <sjg at chromium.org>
> > >---
> > >
> > >(no changes since v1)
> > >
> > > common/Kconfig | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > >diff --git a/common/Kconfig b/common/Kconfig
> > >index 0b09bd68bd13..844531a59eda 100644
> > >--- a/common/Kconfig
> > >+++ b/common/Kconfig
> > >@@ -1169,12 +1169,12 @@ config IO_TRACE
> > > 	bool
> > > 
> > > config BMP
> > >-	bool "Enable bmp image display"
> > >+	bool # Enable bmp image display
> 
> Just change this to "bool" and don't add non-prompt text.  The help
> should be made clearer if it's not already.
> 
> > This must depend on video.
> 
> Since it's only select'd, no, it should be selected with "if VIDEO" if
> the options that actually use them don't already depend on video
> 
> > 
> > > 	help
> > > 	  Enable bmp functions to display bmp image and get bmp info.
> > > 
> > > config SPL_BMP
> > >-	bool "Enable bmp image display at SPL"
> > >+	bool # Enable bmp image display at SPL
> > 
> > Why should I not be able to deactivate the logo display?
> 
> That's SPLASH_SCREEN not BMP.

Sorry, you're right Heinrich, the further options here depend on, not
select SPL_BMP.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230831/7a3d109d/attachment.sig>