[PATCH] mmc: Poll CD in case cyclic framework is enabled

Stefan Roese sr at denx.de
Mon Dec 4 08:27:10 CET 2023


On 12/4/23 02:05, Marek Vasut wrote:
> On 12/4/23 01:44, Simon Glass wrote:
>> Hi Marek,
>>
>> On Sun, 3 Dec 2023 at 14:01, Marek Vasut <marek.vasut at mailbox.org> wrote:
>>>
>>> On 12/3/23 18:44, Simon Glass wrote:
>>>> Hi Marek,
>>>>
>>>> On Sat, 2 Dec 2023 at 16:41, Marek Vasut
>>>> <marek.vasut+renesas at mailbox.org> wrote:
>>>>>
>>>>> In case the cyclic framework is enabled, poll the card detect of 
>>>>> already
>>>>> initialized cards and deinitialize them in case they are removed. 
>>>>> Since
>>>>> the card initialization is a longer process and card initialization is
>>>>> done on first access to an uninitialized card anyway, avoid 
>>>>> initializing
>>>>> newly detected uninitialized cards in the cyclic callback.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
>>>>> ---
>>>>> Cc: Jaehoon Chung <jh80.chung at samsung.com>
>>>>> Cc: Peng Fan <peng.fan at nxp.com>
>>>>> ---
>>>>>    drivers/mmc/mmc-uclass.c | 27 +++++++++++++++++++++++++++
>>>>>    1 file changed, 27 insertions(+)
>>>>
>>>> This is really nice!
>>>
>>> I wonder whether we can use this cyclic stuff for USB , that's on my
>>> roadmap to look at . We could auto-detect new devices in the background,
>>> which would be tidy. And maybe do block transfers in the background ?
>>
>> Just the detect would be amazing!!
>>
>> One thing on my mind is that we could have a console buffer, so that
>> output from background tasks can be collected and written just before
>> displaying the U-Boot prompt. I am itching to implement that part of
>> it :-)
> 
> And a 'dmesg' command to go along with it ?
> 
> Go for it.

It's very nice to see, that the cyclic infrastructure is finally getting
used by other interfaces / devices etc. Really interesting. I assume
there are many more potential use cases where it may be helpful.

Thanks for all your work on this,
Stefan


More information about the U-Boot mailing list