[PATCH v2 12/18] bloblist: Reduce bloblist header size

Simon Glass sjg at chromium.org
Tue Dec 5 01:52:05 CET 2023


Hi,

On Mon, 4 Dec 2023 at 01:39, Ilias Apalodimas
<ilias.apalodimas at linaro.org> wrote:
>
> Ah I guess this fixes my concerns on patch #6
>
> On Mon, 27 Nov 2023 at 21:53, Raymond Mao <raymond.mao at linaro.org> wrote:
> >
> > From: Simon Glass <sjg at chromium.org>
> >
> > The v0.9 spec provides for a 16-byte header with fewer fields. Update
> > the implementation to match this.
> >
> > This also adds an alignment field.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
> > ---
> >  include/bloblist.h | 26 +++++++++++++-------------
> >  test/bloblist.c    |  6 +++---
> >  2 files changed, 16 insertions(+), 16 deletions(-)
>
>
>
>
> >
> > diff --git a/include/bloblist.h b/include/bloblist.h
> > index 745bcdd227..57625ea004 100644
> > --- a/include/bloblist.h
> > +++ b/include/bloblist.h
> > @@ -164,30 +164,30 @@ enum bloblist_tag_t {
> >   * from the last.
> >   *
> >   * @magic: BLOBLIST_MAGIC
> > + * @chksum: checksum for the entire bloblist allocated area. Since any of the
> > + *     blobs can be altered after being created, this checksum is only valid
> > + *     when the bloblist is finalised before jumping to the next stage of boot.
> > + *     This is the value needed to make all chechksummed bytes sum to 0
>
> typos checksummed and finalized

finalised is correct

>
> [...]
>
> With the typos fixed
>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

REgards,
Simon


More information about the U-Boot mailing list