[PATCH v5 09/17] board: ti: j784s4: Add board support for J784S4 EVM

[Apurva Nandan]

Hi Marcel

On 01/12/23 14:13, Marcel Ziswiler wrote:
> Hi Apurva
>
> Thanks for the update, however, it does not seem to compile. See below...
>
> On Thu, 2023-11-30 at 17:25 +0530, Apurva Nandan wrote:
>> Add board files for J784S4 EVM.
>>
>> Signed-off-by: Hari Nagalla <hnagalla at ti.com>
>> [ add env and board specific yaml files for binman ]
>> Signed-off-by: Neha Malcom Francis <n-francis at ti.com>
>> [ cleaned up the env files ]
>> Signed-off-by: Manorit Chawdhry <m-chawdhry at ti.com>
>> Signed-off-by: Dasnavis Sabiya <sabiya.d at ti.com>
>> Signed-off-by: Apurva Nandan <a-nandan at ti.com>
>> ---
>>   arch/arm/mach-k3/Kconfig        |  1 +
>>   arch/arm/mach-k3/j784s4/Kconfig | 35 ++++++++++++++++++++++++++++++
>>   board/ti/j784s4/Makefile        |  7 ++++++
>>   board/ti/j784s4/evm.c           | 38 +++++++++++++++++++++++++++++++++
>>   include/configs/j784s4_evm.h    | 20 +++++++++++++++++
>>   5 files changed, 101 insertions(+)
>>   create mode 100644 arch/arm/mach-k3/j784s4/Kconfig
>>   create mode 100644 board/ti/j784s4/Makefile
>>   create mode 100644 board/ti/j784s4/evm.c
>>   create mode 100644 include/configs/j784s4_evm.h
>>
>> diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig
>> index 150d0bfa14..445b49e245 100644
>> --- a/arch/arm/mach-k3/Kconfig
>> +++ b/arch/arm/mach-k3/Kconfig
>> @@ -157,5 +157,6 @@ source "arch/arm/mach-k3/am62x/Kconfig"
>>   source "arch/arm/mach-k3/am62ax/Kconfig"
>>   source "arch/arm/mach-k3/j721e/Kconfig"
>>   source "arch/arm/mach-k3/j721s2/Kconfig"
>> +source "arch/arm/mach-k3/j784s4/Kconfig"
>>   
>>   endif
>> diff --git a/arch/arm/mach-k3/j784s4/Kconfig b/arch/arm/mach-k3/j784s4/Kconfig
>> new file mode 100644
>> index 0000000000..03d3f91371
>> --- /dev/null
>> +++ b/arch/arm/mach-k3/j784s4/Kconfig
>> @@ -0,0 +1,35 @@
>> +# SPDX-License-Identifier: GPL-2.0-or-later
>> +#
>> +# Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> +#	Hari Nagalla <hnagalla at ti.com>
>> +
>> +if SOC_K3_J784S4
>> +
>> +choice
>> +	prompt "K3 J784S4 board"
>> +	optional
>> +
>> +config TARGET_J784S4_A72_EVM
>> +	bool "TI K3 based J784S4 EVM running on A72"
>> +	select ARM64
>> +	select BOARD_LATE_INIT
>> +	select SYS_DISABLE_DCACHE_OPS
>> +	select BINMAN
>> +
>> +config TARGET_J784S4_R5_EVM
>> +	bool "TI K3 based J784S4 EVM running on R5"
>> +	select CPU_V7R
>> +	select SYS_THUMB_BUILD
>> +	select K3_LOAD_SYSFW
>> +	select RAM
>> +	select SPL_RAM
>> +	select K3_DDRSS
>> +	select BINMAN
>> +	imply SYS_K3_SPL_ATF
>> +
>> +endchoice
>> +
>> +source "board/ti/j784s4/Kconfig"
> Where exactly would that one come from?
>
> ⬢[zim at toolbox u-boot.git]$ make j784s4_evm_r5_defconfig
>    HOSTCC  scripts/basic/fixdep
>    HOSTCC  scripts/kconfig/conf.o
>    YACC    scripts/kconfig/zconf.tab.c
>    LEX     scripts/kconfig/zconf.lex.c
>    HOSTCC  scripts/kconfig/zconf.tab.o
>    HOSTLD  scripts/kconfig/conf
> arch/arm/mach-k3/j784s4/Kconfig:32: can't open file "board/ti/j784s4/Kconfig"
> make[1]: *** [scripts/kconfig/Makefile:96: j784s4_evm_r5_defconfig] Error 1
> make: *** [Makefile:586: j784s4_evm_r5_defconfig] Error 2
Sorry, somehow I missed to push the Kconfig file in the patch. I will 
fix it in the v6.
Thanks for pointing!
>> +
>> +endif
>> +
>> diff --git a/board/ti/j784s4/Makefile b/board/ti/j784s4/Makefile
>> new file mode 100644
>> index 0000000000..3fc70eb8fb
>> --- /dev/null
>> +++ b/board/ti/j784s4/Makefile
>> @@ -0,0 +1,7 @@
>> +# SPDX-License-Identifier: GPL-2.0-or-later
>> +#
>> +# Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> +#	Hari Nagalla <hnagalla at ti.com>
>> +#
>> +
>> +obj-y += evm.o
>> diff --git a/board/ti/j784s4/evm.c b/board/ti/j784s4/evm.c
>> new file mode 100644
>> index 0000000000..4857c9d2f6
>> --- /dev/null
>> +++ b/board/ti/j784s4/evm.c
>> @@ -0,0 +1,38 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * Board specific initialization for J784S4 EVM
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *	Hari Nagalla <hnagalla at ti.com>
>> + *
>> + */
>> +
>> +#include <image.h>
>> +#include <init.h>
>> +#include <spl.h>
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +int board_init(void)
>> +{
>> +	return 0;
>> +}
>> +
>> +int dram_init(void)
>> +{
>> +	return fdtdec_setup_mem_size_base();
>> +}
>> +
>> +int dram_init_banksize(void)
>> +{
>> +	return fdtdec_setup_memory_banksize();
>> +}
>> +
>> +int board_late_init(void)
>> +{
>> +	return 0;
>> +}
>> +
>> +void spl_board_init(void)
>> +{
>> +}
>> diff --git a/include/configs/j784s4_evm.h b/include/configs/j784s4_evm.h
>> new file mode 100644
>> index 0000000000..1b780134ca
>> --- /dev/null
>> +++ b/include/configs/j784s4_evm.h
>> @@ -0,0 +1,20 @@
>> +/* SPDX-License-Identifier: GPL-2.0-or-later */
>> +/*
>> + * Configuration header file for K3 J784S4 EVM
>> + *
>> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
>> + *	Hari Nagalla <hnagalla at ti.com>
>> + */
>> +
>> +#ifndef __CONFIG_J784S4_EVM_H
>> +#define __CONFIG_J784S4_EVM_H
>> +
>> +#include <linux/sizes.h>
>> +
>> +/* DDR Configuration */
>> +#define CFG_SYS_SDRAM_BASE1		0x880000000
>> +
>> +/* Now for the remaining common defines */
>> +#include <configs/ti_armv7_common.h>
>> +
>> +#endif /* __CONFIG_J784S4_EVM_H */
> Cheers
>
> Marcel

-- 
Regards,
Apurva Nandan,
Texas Instruments.