[PATCH 1/2] tee: optee: don't fail on services enumeration failure

Jens Wiklander jens.wiklander at linaro.org
Tue Dec 5 16:14:38 CET 2023


On Wed, Nov 29, 2023 at 1:37 PM Etienne Carriere
<etienne.carriere at foss.st.com> wrote:
>
> Change optee probe function to only warn when service enumeration
> sequence fails instead of reporting an optee driver probe failure.
> Indeed U-Boot can still use OP-TEE even if some OP-TEE services are
> not discovered.
>
> Fixes: 94ccfb78a4d6 ("drivers: tee: optee: discover OP-TEE services")
> Signed-off-by: Etienne Carriere <etienne.carriere at foss.st.com>
> ---
>  drivers/tee/optee/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index 9a9b697e91..5308dd58ce 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -841,7 +841,7 @@ static int optee_probe(struct udevice *dev)
>         if (IS_ENABLED(CONFIG_OPTEE_SERVICE_DISCOVERY)) {
>                 ret = bind_service_drivers(dev);
>                 if (ret)
> -                       return ret;
> +                       dev_warn(dev, "optee service enumeration failed: %d\n", ret);
>         } else if (IS_ENABLED(CONFIG_RNG_OPTEE)) {
>                 /*
>                  * Discovery of TAs on the TEE bus is not supported in U-Boot:
> --
> 2.25.1
>

Looks good.
Reviewed-by: Jens Wiklander <jens.wiklander at linaro.org>

Thanks,
Jens


More information about the U-Boot mailing list