[PATCH v2 1/3] mtd: spi-nor: Add support for zBIT ZB25VQ128

[Dragan Simic]

Hello Andre,

On 2023-12-06 17:24, Andre Przywara wrote:
> On Mon,  4 Dec 2023 00:59:52 +0000 Andre Przywara 
> <andre.przywara at arm.com> wrote:
>> Add support for the zBIT ZB25VQ128 (128M-bit) SPI NOR flash memory 
>> chip,
>> as used on the Xunlong Orange Pi Zero 3 board.
> 
> does anyone have any objections against this patch? I wanted to take 
> this
> via the sunxi tree, as this blocks some board support patches.

The patch looks perfectly fine to me.  Thus,

Reviewed-by: Dragan Simic <dsimic at manjaro.org>

> IIUC Linux gave up on adding rather generic entries up for each and 
> every
> SPI NOR chip, if there is nothing special about them:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=773bbe1044
> Should we follow suit here?

I think it would be good to employ the same approach, to make it easier 
to support more chips and more boards in the future.  Also, at least a 
few already existing chip definitions could be dropped, after testing, 
of course.  Simplifying the things is almost always a good choice.

As visible in [1] and [2], the Linux kernel no longer accepts entries 
for the chips that can be detected automatically and don't require some 
specific fixes.

[1] 
https://lore.kernel.org/linux-mtd/542998283b464d19fa5f354898de79df@walle.cc/T/#t
[2] 
https://lore.kernel.org/linux-mtd/20231123160721.64561-2-tudor.ambarus@linaro.org/

>> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>> ---
>>  drivers/mtd/spi/Kconfig       | 5 +++++
>>  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
>>  2 files changed, 10 insertions(+)
>> 
>> diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
>> index 732b0760452..abed392c28d 100644
>> --- a/drivers/mtd/spi/Kconfig
>> +++ b/drivers/mtd/spi/Kconfig
>> @@ -224,6 +224,11 @@ config SPI_FLASH_XTX
>>  	  Add support for various XTX (XTX Technology Limited)
>>  	  SPI flash chips (XT25xxx).
>> 
>> +config SPI_FLASH_ZBIT
>> +	bool "ZBIT SPI flash support"
>> +	help
>> +	  Add support for Zbit Semiconductor Inc. SPI flash chips (ZB25xxx).
>> +
>>  endif
>> 
>>  config SPI_FLASH_USE_4K_SECTORS
>> diff --git a/drivers/mtd/spi/spi-nor-ids.c 
>> b/drivers/mtd/spi/spi-nor-ids.c
>> index 3cb132dcffc..f86e7ff8e58 100644
>> --- a/drivers/mtd/spi/spi-nor-ids.c
>> +++ b/drivers/mtd/spi/spi-nor-ids.c
>> @@ -571,6 +571,11 @@ const struct flash_info spi_nor_ids[] = {
>>  	       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | 
>> SPI_NOR_4B_OPCODES) },
>>  	{ INFO("xt25w01g", 0x0b651B, 0, 64 * 1024, 2048,
>>  	       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | 
>> SPI_NOR_4B_OPCODES) },
>> +#endif
>> +#ifdef CONFIG_SPI_FLASH_ZBIT
>> +	/* Zbit Semiconductor Inc. */
>> +	{ INFO("zb25vq128", 0x5e4018, 0, 64 * 1024, 256,
>> +	       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>>  #endif
>>  	{ },
>>  };