[PATCH v2 02/18] bloblist: Adjust API to align in powers of 2

[Simon Glass]

Hi Raymond,

On Wed, 6 Dec 2023 at 13:08, Raymond Mao <raymond.mao at linaro.org> wrote:
>
> Hi Simon,
>
> I am wondering if I shall put in your review tag as you are one of the authors of many patches...
> What is the best approach under this situation in the U-Boot community?

Well, where it is modified by you, I think it is reasonable to add my review.

Regards,
Simon


>
> Thanks and regards,
> Raymond
>
> On Sat, 2 Dec 2023 at 13:33, Simon Glass <sjg at chromium.org> wrote:
>>
>> On Mon, 27 Nov 2023 at 12:52, Raymond Mao <raymond.mao at linaro.org> wrote:
>> >
>> > From: Simon Glass <sjg at chromium.org>
>> >
>> > The updated bloblist structure stores the alignment as a power-of-two
>> > value in its structures. Adjust the API to use this, to avoid needing to
>> > calling ilog2().
>> >
>> > Drop a stale comment while we are here.
>> >
>> > Signed-off-by: Simon Glass <sjg at chromium.org>
>> > Co-developed-by: Raymond Mao <raymond.mao at linaro.org>
>> > Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
>> > ---
>> > Changes in v2
>> > - Update the bloblist alignment to align to FW handoff spec v0.9.
>> >
>> >  arch/x86/lib/tables.c |  3 ++-
>> >  common/bloblist.c     | 24 +++++++++++-------------
>> >  include/bloblist.h    | 12 +++++++-----
>> >  test/bloblist.c       |  4 ++--
>> >  4 files changed, 22 insertions(+), 21 deletions(-)
>> >
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>