[PATCH 1/1] binman: elf: Using variable 'old_val' before assignment

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Mon Dec 11 18:56:45 CET 2023


On 11.12.23 18:52, Simon Glass wrote:
> On Sat, 9 Dec 2023 at 11:50, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
>>
>> old_val can only be assumed initialized in the finally block
>> if it is assigned a value before the try statement.
>>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> ---
>>   tools/binman/elf_test.py | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/binman/elf_test.py b/tools/binman/elf_test.py
>> index e3dee79d06..b64134123c 100644
>> --- a/tools/binman/elf_test.py
>> +++ b/tools/binman/elf_test.py
>> @@ -249,8 +249,8 @@ class TestElf(unittest.TestCase):
>>
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> An odd case though...I cannot imagine how this might fail.

This patch is needed to use a recent pylint. Otherwise 'make pylint_err' 
will fail in future.

Best regards

Heinrich


More information about the U-Boot mailing list